Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ django 4.2 #2976

Merged
merged 1 commit into from
Apr 18, 2024
Merged

⬆️ django 4.2 #2976

merged 1 commit into from
Apr 18, 2024

Conversation

nikolas
Copy link
Member

@nikolas nikolas commented Oct 13, 2023

No description provided.

@nikolas nikolas self-assigned this Oct 13, 2023
@nikolas nikolas force-pushed the django-4 branch 3 times, most recently from 3fe9c24 to bb7348e Compare October 13, 2023 18:07
@nikolas nikolas removed their assignment Oct 13, 2023
@nikolas nikolas force-pushed the django-4 branch 2 times, most recently from 6e1a103 to 4705091 Compare October 13, 2023 18:21
@nikolas nikolas self-assigned this Oct 13, 2023
@nikolas nikolas force-pushed the django-4 branch 2 times, most recently from c94044d to d188f8b Compare November 2, 2023 18:08
@nikolas nikolas changed the title ⬆️ django 4.2.6 ⬆️ django 4.2.7 Nov 2, 2023
@nikolas
Copy link
Member Author

nikolas commented Nov 2, 2023

There seems to be a bug with running spatialite 5 and django 4.2, that I'm seeing in my dev environment. Details here:

@nikolas nikolas removed their assignment Jan 18, 2024
@nikolas nikolas marked this pull request as ready for review April 17, 2024 13:49
@nikolas nikolas changed the title ⬆️ django 4.2.7 ⬆️ django 4.2 Apr 17, 2024
@nikolas nikolas force-pushed the django-4 branch 6 times, most recently from fedc3bb to 92bd117 Compare April 17, 2024 14:05
@nikolas
Copy link
Member Author

nikolas commented Apr 17, 2024

@nikolas
Copy link
Member Author

nikolas commented Apr 17, 2024

It sounds like updating to Spatialite 5.1 would fix the issue: https://stackoverflow.com/a/78343541/173630

Now we just have to figure out how to set that up and build it on github actions and jenkins.

Also, this upstream patch fixes the issue for spatialite 5.0.1: django/django#18083

@nikolas nikolas force-pushed the django-4 branch 2 times, most recently from 1ee45a3 to 1c81137 Compare April 18, 2024 15:05
@nikolas nikolas self-assigned this Apr 18, 2024
@nikolas nikolas force-pushed the django-4 branch 7 times, most recently from ae44c05 to 8eaef88 Compare April 18, 2024 15:31
@nikolas nikolas assigned ndittren and unassigned nikolas Apr 18, 2024
@nikolas
Copy link
Member Author

nikolas commented Apr 18, 2024

@ndittren this should be good to deploy as long as we avoid the spatialite versions 5.0 / 5.0.1. Production is currently on ubuntu 20, which uses spatialite 4.3. In my dev environment I do have spatialite 5.0.1, and I'm working around this bug by manually applying this patch in django's code in my venv: django/django#18083

Moving forward, Ubuntu 24 is about to be released, and comes with Spatialite 5.1, and this bug is apparently fixed there.

@nikolas nikolas force-pushed the django-4 branch 2 times, most recently from 7c06030 to 83a3742 Compare April 18, 2024 15:40
@ndittren
Copy link
Member

@nikolas Okay looks good to me. Footprints prod currently has an unhealthygroup alarm on cloudwatch. Should we wait for that to clear up?

@nikolas
Copy link
Member Author

nikolas commented Apr 18, 2024

I think this can go through now that the alarm is green and footprints is fixed.

@ndittren ndittren merged commit 8344a02 into master Apr 18, 2024
5 checks passed
@ndittren ndittren deleted the django-4 branch April 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants