Skip to content

Commit

Permalink
Fix/formatter check in ci (#205)
Browse files Browse the repository at this point in the history
* Ensure make test runs ruff format --check

* Remove unnecessary ruff check

- Doing  is redundant as isort is enabled by default, removed the rule selector
  • Loading branch information
whabanks authored Dec 13, 2024
1 parent bba6369 commit 982d70f
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 23 deletions.
8 changes: 6 additions & 2 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,13 @@
"customizations": {
"vscode": {
"settings": {
"ruff.lint.ignore": ["F401"],
"ruff.lint.run": "onSave",
"ruff.organizeImports": false,
"[python]": {
"editor.formatOnSave": true
},"python.pythonPath": "/usr/local/bin/python"
"editor.defaultFormatter": "charliermarsh.ruff"
},
"python.pythonPath": "/usr/local/bin/python"
},
"extensions": [
"charliermarsh.ruff",
Expand Down
4 changes: 3 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ run-gunicorn:

.PHONY: test
test:
poetry run ruff check .
poetry run ruff check --select I .
poetry run ruff format --check .
poetry run mypy .
poetry run py.test --cov=app --cov-report=term-missing tests/

Expand All @@ -26,6 +28,6 @@ test-requirements:

.PHONY: format
format:
ruff check --select I --fix .
ruff check --fix .
ruff check
ruff format .
39 changes: 20 additions & 19 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pytest-env = "0.8.1"
pytest-mock = "3.14.0"

requests-mock = "1.10.0"
ruff = "^0.2.1"
ruff = "^0.8.2"
types-requests = "2.28.11"


Expand Down

0 comments on commit 982d70f

Please sign in to comment.