feat: Inspect policies in the store #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charithe
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Since both ListPolicies and InspectPolicies have the same set of filtering options, it'd better to introduce a new type called FilterOptions and share that with both functions. We should be able to add a type alias for ListPoliciesOption = FilterOptions to avoid breaking existing clients.
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
charithe
reviewed
Apr 8, 2024
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
charithe
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent name conflicts between function names of the
type InspectPoliciesOption func(*requestv1.InspectPoliciesRequest)andtype ListPoliciesOption func(*requestv1.ListPoliciesRequest), I prefixed the formers' function names withInspectPoliciesWith. I am not sure if this is a good idea or not.