OTA single bank firmware swapping #2420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
reviewed
Oct 10, 2023
| @@ -0,0 +1,3 @@ | |||
| # Baremetal web device dashboard on NUCLEO-H743ZI | |||
Comment on lines
39
to
48
| mg_log_set(MG_LL_DEBUG); // Set log level | ||
| mg_ota_bootloader(); | ||
|
|
||
| MG_INFO(("Chip revision: %c, max cpu clock: %u MHz", chiprev(), | ||
| (chiprev() == 'V') ? 480 : 400)); | ||
| MG_INFO(("Starting, CPU freq %g MHz", (double) SystemCoreClock / 1000000)); | ||
|
|
||
| struct mg_mgr mgr; // Initialise | ||
| mg_mgr_init(&mgr); // Mongoose event manager | ||
| mg_log_set(MG_LL_DEBUG); // Set log level |
There was a problem hiding this comment.
mg_log_set is called twice with the same argument
Maybe first one is not needed ?
src/config.h
Outdated
Comment on lines
7
to
10
| #ifndef MG_ENABLE_CUSTOM_LOG | ||
| #define MG_ENABLE_CUSTOM_LOG 0 // Let user define their own MG_LOG | ||
| #endif | ||
|
|
Comment on lines
13
to
+16
| #define FLASH_CCR 0x14 | ||
| #define FLASH_OPTSR_CUR 0x1c | ||
| #define FLASH_OPTSR_PRG 0x20 | ||
| #define FLASH_SIZE_REG 0x1FF1E880 |
There was a problem hiding this comment.
I still prefer FLASH->CCR and so, though I understand it complicates things...
src/log.c
Outdated
Comment on lines
29
to
32
| #if MG_ENABLE_CUSTOM_LOG | ||
| // Let user define their own mg_log_prefix() and mg_log() | ||
| #else | ||
| bool mg_log_prefix(int level, const char *file, int line, const char *fname) { |
src/ota.h
Outdated
Comment on lines
17
to
23
| #if defined(__GNUC__) && !defined(__APPLE__) | ||
| #undef MG_IRAM | ||
| #define MG_IRAM __attribute__((section(".iram"))) | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I see all ota functions (most ?) are prefixed with this.
Do all of them need to run in RAM ? Maybe not the case for dual bank devices, or are those not called/used with dual bank devices ?
There was a problem hiding this comment.
Only if the device is single bank do they need to run in RAM. Perhaps we could add a condition on line 17 to also check if the device is single bank?
robertc2000
force-pushed
the
ota-single-bank-1
branch
5 times, most recently
from
a05eed9 to
27b6397
Compare
robertc2000
force-pushed
the
ota-single-bank-1
branch
from
27b6397 to
153553a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.