mqtt dashboard compatibility with hal.h functions #2516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
reviewed
Dec 7, 2023
| @@ -12,7 +12,7 @@ static struct mg_rpc *s_rpc_head = NULL; | |||
|
|
|||
| struct device_config { | |||
| bool led_status; | |||
| uint8_t led_pin; | |||
| uint16_t led_pin; | |||
scaprile
reviewed
Dec 7, 2023
Comment on lines
+114
to
+116
| if (tmp_pin >= 0) s_device_config.led_pin = tmp_pin; | ||
|
|
||
| if (tmp_pin > 0 && ok) { | ||
| if (tmp_pin >= 0 && ok) { |
There was a problem hiding this comment.
"0" is a valid pin number
scaprile
reviewed
Dec 7, 2023
| @@ -238,6 +238,7 @@ void web_init(struct mg_mgr *mgr) { | |||
| if (!g_device_id) generate_device_id(); | |||
| if (!g_root_topic) g_root_topic = DEFAULT_ROOT_TOPIC; | |||
| s_device_config.log_level = (uint8_t) mg_log_level; | |||
| s_device_config.led_pin = LED; | |||
There was a problem hiding this comment.
default to LED pin in real hw
scaprile
reviewed
Dec 7, 2023
| @@ -27,7 +27,6 @@ pico_enable_stdio_uart(firmware 1) # to the UART | |||
| add_definitions(-DMG_ENABLE_TCPIP=1) | |||
| add_definitions(-DMG_ENABLE_PACKED_FS=1) | |||
| add_definitions(-DMG_ENABLE_FILE=0) | |||
| add_definitions(-DDISABLE_ROUTING=1) | |||
scaprile
reviewed
Dec 7, 2023
| static bool s_pins[100]; | ||
|
|
||
| void gpio_write(int pin, bool status) { | ||
| if (pin >= 0 && pin <= (int) (sizeof(s_pins) / sizeof(s_pins[0]))) { |
There was a problem hiding this comment.
"=" was actually out of bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.