Split PHY code into phy.{c,h} #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaprile
force-pushed
the
phy
branch
3 times, most recently
from
d3b848c to
811c32c
Compare
cpq
commented
Mar 15, 2024
src/drivers/phy.h
Outdated
| void (*write_reg)(uint8_t addr, uint8_t reg, uint16_t value); | ||
| }; | ||
|
|
||
| enum { MG_PHY_CONF_CLOCKING = 0, MG_PHY_CONF_CLOCKED = 1, MG_PHY_CONF_LEDS_AH = 2}; |
There was a problem hiding this comment.
I don't understand those values...
Could you choose a bit more descriptive names, perhaps longer ones?
Or, add comments (more descriptive names are preferred, cause comments are not visible where those values are used)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.