chore: refactor all_ontology_generator for cleanliness and modularity #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bento007
reviewed
Feb 13, 2024
Bento007
requested changes
Feb 13, 2024
| @@ -12,22 +12,21 @@ | |||
| import yaml | |||
|
|
|||
|
|
|||
| def _download_owls(owl_info_yml: str = env.OWL_INFO_YAML, output_dir: str = env.ONTOLOGY_DIR): | |||
| def _download_ontologies(onto_info_yml: str = env.ONTO_INFO_YAML, output_dir: str = env.RAW_ONTOLOGY_DIR): | |||
There was a problem hiding this comment.
this might be used later as part of the API https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/gh/chanzuckerberg/cellxgene-ontology-guide/22
There was a problem hiding this comment.
should we add a TODO to replace with that function once its created? or create it now as part of this PR?
There was a problem hiding this comment.
I'll update the ticket to reference this code.
Bento007
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all_ontology_generator easier to read and change, should we decide to change implementation details (parsing library, file download logic, adding or removing metadata fields, etc.)