Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set closed at as merged at when closed at is missing #2955

Merged
merged 1 commit into from
Dec 5, 2024
Merged

set closed at as merged at when closed at is missing #2955

merged 1 commit into from
Dec 5, 2024

Conversation

ABrain7710
Copy link
Contributor

Description

  • Set gitlab pr closed at to the merged at date if pr closed at is not set

Signed commits

  • Yes, I signed my commits.

Ulincsys
Ulincsys approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Ulincsys Ulincsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgoggins sgoggins self-assigned this Dec 5, 2024
@sgoggins sgoggins added the bug-fix Fixes a bug label Dec 5, 2024
@sgoggins sgoggins linked an issue Dec 5, 2024 that may be closed by this pull request
BUG: Gitlab repository pull_requests pr_closed_at column null when pr is merged #2924
Open
@sgoggins sgoggins merged commit 1a3a70b into dev Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ulincsys Ulincsys Ulincsys approved these changes

Assignees

@sgoggins sgoggins

Labels
bug-fix Fixes a bug
Projects
Augur TSC
Status: Main
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Gitlab repository pull_requests pr_closed_at column null when pr is merged
3 participants
@ABrain7710 @Ulincsys @sgoggins