ci: fix rawhide netlink error #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rawhide netlink errors are fixed with a newer kernel than the default 6.2 available in Fedora 38. Signed-off-by: Adrian Reber <areber@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2304 +/- ##
============================================
- Coverage 70.29% 70.29% -0.01%
============================================
Files 134 134
Lines 34040 34040
============================================
- Hits 23929 23928 -1
- Misses 10111 10112 +1 ☔ View full report in Codecov by Sentry. |
The old test was checking if '/' is btrfs but we should check if the current directory is btrfs. Signed-off-by: Adrian Reber <areber@redhat.com>
rst0git
reviewed
Nov 29, 2023
| # zdtm/static/socket-tcp-nfconntrack. To activate the new kernel previously | ||
| # installed this reboots the VM. | ||
| vagrant reload | ||
| ssh default uname -a |
There was a problem hiding this comment.
Would it be better to move vagrant reload in setup() for consistency across tests?
There was a problem hiding this comment.
I was thinking about it, but if we do not need the latest kernel rebooting takes additional time.
adrianreber
merged commit 4213f16
into
checkpoint-restore:criu-dev
35 of 40 checks passed
|
Sorry. I merged this. This was not my intention. |
|
@avagin Can you undo this while rebasing? I can also to a revert. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rawhide netlink errors are fixed with a newer kernel than the default 6.2 available in Fedora 38.