Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Timer Handling and Testing for One Shot Timer #2562

Open
wants to merge 2 commits into
base: criu-dev
Choose a base branch
from
Open

Enhanced Timer Handling and Testing for One Shot Timer #2562

wants to merge 2 commits into from

Conversation

hckuo
Copy link

@hckuo hckuo commented Jan 8, 2025 •
edited
Loading

This pull request introduces improvements to timer handling and testing:

  1. Timer Handling Updates

    • Modified the itimer_armed macro in restorer.c to properly consider the it_value field.
    • Simplified the decode_itimer function in timer.c to utilize the provided it_value.
    • Removed conditional logic that previously set it_value to interval, ensuring more accurate timer behavior.

  2. ZDTM Test Enhancements

    • Refactored setup_timers() function to accept a timer configuration parameter, allowing for more flexible testing scenarios.
    • Introduced a one-shot timer configuration in addition to the existing periodic timer.
    • Expanded the test suite to run twice, each time with a different timer configuration, providing more comprehensive coverage.

hckuo added 2 commits January 7, 2025 04:31
@hckuo
Update timer handling to properly respect the it_value field
1635543 
- Modify itimer_armed macro in restorer.c to consider it_value
- Simplify decode_itimer function in timer.c to use provided it_value
- Remove conditional logic that set it_value to interval
@hckuo
test: zdtm: Enhance timers test with multiple timer configurations
d5ca42b 
This commit improves the timers test in ZDTM (Zero Downtime Migration) by introducing multiple timer configurations. The changes include:

- Refactoring setup_timers() to accept a timer configuration parameter.
- Adding a one-shot timer configuration alongside the existing periodic timer.
- Running the test twice with different timer configurations.
@hckuo hckuo changed the title Fix one shot itimer Enhanced Timer Handling and Testing for One Shot Timer Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hckuo