Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit code #14

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fix exit code #14

merged 2 commits into from
Nov 24, 2023

Conversation

neovov
Copy link
Contributor

@neovov neovov commented Nov 24, 2023

This fixes #13

@neovov neovov requested a review from fwuensche as a code owner November 24, 2023 16:56
@fwuensche
Copy link
Contributor

🙏

@fwuensche fwuensche merged commit d46d5dd into cherrypush:main Nov 24, 2023
0 of 2 checks passed
@neovov neovov deleted the fix-exit-code branch November 27, 2023 11:12
fwuensche pushed a commit that referenced this pull request Oct 4, 2024
* Exit with an error if /metrics respond with an error

* Exit with an error code when necessary
fwuensche pushed a commit that referenced this pull request Oct 4, 2024
* Exit with an error if /metrics respond with an error

* Exit with an error code when necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On error, cherry diff should return non-zero exit code
2 participants