Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages and fix CSS #68

Merged
merged 10 commits into from
Dec 17, 2023
Merged

Update packages and fix CSS #68

merged 10 commits into from
Dec 17, 2023

Conversation

zAlweNy26
Copy link
Member

Description

Just some tweaks and updates,

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@zAlweNy26
Copy link
Member Author

@kodaline feel free to test it too :)

@EugenioPetulla
Copy link
Contributor

EugenioPetulla commented Dec 17, 2023

The PR is generally good! :D

The only think I'm noticing is that the"upload" and "create" plugin buttons in the plugins page are too big for the scope, we should make them xs in order to better fit the rest of UX.

Did you swapped the order of the Wipe buttons in the memory page? I prefer have it at the bottom.

@zAlweNy26
Copy link
Member Author

The "upload" and "create" plugin buttons are medium size, they seem fine to me, but making them smaller could be a little too much.

For the wipe button on the memory page, it is @kodaline's fault 🤣
I'll move it to bottom, I agree with you.

@kodaline
Copy link
Contributor

The "upload" and "create" plugin buttons are medium size, they seem fine to me, but making them smaller could be a little too much.

For the wipe button on the memory page, it is @kodaline's fault 🤣

I am sorry, when I did the heavy endpoints, I was wiping the memory without using the search bar, so without seeing the 2D memory graph. What was happening was that the wipe buttons where going down as if there was the graph but there wasn't, so I interpreted it as "bug".

Sorry again, @zAlweNy26 I can fix it if you want

@zAlweNy26
Copy link
Member Author

No problem, I fixed it :)

@zAlweNy26 zAlweNy26 merged commit a292158 into develop Dec 17, 2023
2 checks passed
@zAlweNy26 zAlweNy26 deleted the updates branch December 17, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants