Merge pull request #8 from mikeweb85/enhancement/union-reflection-sup…

…port support union type in reflection method
chevere · Jan 3, 2025 · f8800e2 · f8800e2
2 parents ce419c1 + 91234f9
commit f8800e2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 7 deletions.
diff --git a/src/ReflectionParameterTyped.php b/src/ReflectionParameterTyped.php
@@ -26,15 +26,17 @@
 
 final class ReflectionParameterTyped implements ReflectionParameterTypedInterface
 {
-    private ?ReflectionNamedType $type;
+    private ReflectionUnionType|ReflectionNamedType|null $type;
 
     private ParameterInterface $parameter;
 
     public function __construct(
         private ReflectionParameter $reflection
     ) {
         $this->type = $this->getType();
-        $parameter = toParameter($this->type?->getName() ?? 'mixed');
+        $parameter = ($this->type instanceof ReflectionUnionType) ?
+            toUnionParameter($this->type->getTypes()) :
+            toParameter($this->type?->getName() ?? 'mixed');
 
         try {
             $attribute = reflectedParameterAttribute($reflection);
@@ -74,13 +76,13 @@ public function parameter(): ParameterInterface
         return $this->parameter;
     }
 
-    private function getType(): ?ReflectionNamedType
+    private function getType(): ReflectionNamedType|ReflectionUnionType|null
     {
         $reflection = $this->reflection->getType();
         if ($reflection === null) {
             return null;
         }
-        if ($reflection instanceof ReflectionNamedType) {
+        if ($reflection instanceof ReflectionNamedType || $reflection instanceof ReflectionUnionType) {
             return $reflection;
         }
         $name = '$' . $this->reflection->getName();

diff --git a/src/functions.php b/src/functions.php
@@ -37,6 +37,7 @@
 use ReflectionAttribute;
 use ReflectionFunction;
 use ReflectionMethod;
+use ReflectionNamedType;
 use ReflectionParameter;
 use Throwable;
 use function Chevere\Message\message;
@@ -136,6 +137,20 @@ function assertNamedArgument(
     }
 }
 
+function toUnionParameter(array $types): UnionParameterInterface
+{
+    $parameters = [];
+
+    /** @var ReflectionNamedType $type */
+    foreach ($types as $type) {
+        $parameters[] = toParameter($type->getName());
+    }
+
+    $parameters = parameters(...$parameters);
+
+    return new UnionParameter($parameters);
+}
+
 function toParameter(string $type): ParameterInterface
 {
     $class = TypeInterface::TYPE_TO_PARAMETER[$type]

diff --git a/tests/ReflectionParameterTypedTest.php b/tests/ReflectionParameterTypedTest.php
@@ -17,6 +17,7 @@
 use Chevere\Parameter\Interfaces\NullParameterInterface;
 use Chevere\Parameter\Interfaces\ObjectParameterInterface;
 use Chevere\Parameter\Interfaces\StringParameterInterface;
+use Chevere\Parameter\Interfaces\UnionParameterInterface;
 use Chevere\Parameter\ReflectionParameterTyped;
 use Chevere\Tests\src\Depends;
 use LogicException;
@@ -72,9 +73,9 @@ public function testParameterDefault(): void
     public function testUnion(): void
     {
         $parameter = $this->getReflection('useUnion');
-        $this->expectException(LogicException::class);
-        $this->expectExceptionMessage('$union of type union is not supported');
-        new ReflectionParameterTyped($parameter);
+        $reflection = new ReflectionParameterTyped($parameter);
+        $reflected = $reflection->parameter();
+        $this->assertInstanceOf(UnionParameterInterface::class, $reflected);
     }
 
     public function testIntersection(): void