Safer replacement of non-synth constructs #1086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply removing a non-synthesizable construct from the AST can lead to ill-formed parent statements:
Example:
for (int i = 0; .....)
$fdisplay (...) ;
Would become:
for (int i = 0; .....)
And crash during Synthesis due to incomplete for loop statement (No actual statement).
Since the null_stmt is not supported in downstream tools, the safest statement is a dummy $display statement to put in place of the non-supported statement.