Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer replacement of non-synth constructs #1086

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

alaindargelas
Copy link
Collaborator

Simply removing a non-synthesizable construct from the AST can lead to ill-formed parent statements:
Example:
for (int i = 0; .....)
$fdisplay (...) ;

Would become:

for (int i = 0; .....)

And crash during Synthesis due to incomplete for loop statement (No actual statement).

Since the null_stmt is not supported in downstream tools, the safest statement is a dummy $display statement to put in place of the non-supported statement.

@alaindargelas alaindargelas merged commit 1db369a into chipsalliance:master Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant