Disallow infinite values for partition interval in create_time_partit…

…ions udf (#7822)

PG17 added +/- infinity values for the interval data type
Relevant PG commit:
postgres/postgres@519fc1bd9

src/backend/distributed/sql/citus--12.1-1--13.0-1.sql

@@ -2,3 +2,4 @@
 
 -- bump version to 13.0-1
 #include "udfs/citus_prepare_pg_upgrade/13.0-1.sql"
+#include "udfs/create_time_partitions/13.0-1.sql"

src/backend/distributed/sql/downgrades/citus--13.0-1--12.1-1.sql

@@ -1,2 +1,4 @@
 -- citus--13.0-1--12.1-1
 -- this is an empty downgrade path since citus--12.1-1--13.0-1.sql is empty
+
+#include "../udfs/create_time_partitions/10.2-1.sql"

src/backend/distributed/sql/udfs/create_time_partitions/latest.sql

@@ -21,6 +21,10 @@ BEGIN
         RAISE 'start_from (%) must be older than end_at (%)', start_from, end_at;
     END IF;
 
+    IF NOT isfinite(partition_interval) THEN
+        RAISE 'Partition interval must be a finite value';
+    END IF;
+
     SELECT nspname, relname
     INTO schema_name_text, table_name_text
     FROM pg_class JOIN pg_namespace ON pg_class.relnamespace = pg_namespace.oid

src/test/regress/expected/pg17.out

@@ -1453,6 +1453,21 @@ ROLLBACK;
 NOTICE:  issuing ROLLBACK
 DETAIL:  on server postgres@localhost:xxxxx connectionId: xxxxxxx
 -- End of Testing AT LOCAL option
+-- interval can have infinite values
+-- Relevant PG17 commit: https://github.com/postgres/postgres/commit/519fc1bd9
+-- disallow those in create_time_partitions
+-- test create_time_partitions with infinity values
+CREATE TABLE date_partitioned_table(
+ measureid integer,
+ eventdate date,
+ measure_data jsonb) PARTITION BY RANGE(eventdate);
+SELECT create_time_partitions('date_partitioned_table', INTERVAL 'infinity', '2022-01-01', '2021-01-01');
+ERROR:  Partition interval must be a finite value
+CONTEXT:  PL/pgSQL function create_time_partitions(regclass,interval,timestamp with time zone,timestamp with time zone) line XX at RAISE
+SELECT create_time_partitions('date_partitioned_table', INTERVAL '-infinity', '2022-01-01', '2021-01-01');
+ERROR:  Partition interval must be a finite value
+CONTEXT:  PL/pgSQL function create_time_partitions(regclass,interval,timestamp with time zone,timestamp with time zone) line XX at RAISE
+-- end of testing interval with infinite values
 \set VERBOSITY terse
 SET client_min_messages TO WARNING;
 DROP SCHEMA pg17 CASCADE;

src/test/regress/sql/pg17.sql

@@ -797,6 +797,21 @@ ROLLBACK;
 
 -- End of Testing AT LOCAL option
 
+-- interval can have infinite values
+-- Relevant PG17 commit: https://github.com/postgres/postgres/commit/519fc1bd9
+-- disallow those in create_time_partitions
+
+-- test create_time_partitions with infinity values
+CREATE TABLE date_partitioned_table(
+ measureid integer,
+ eventdate date,
+ measure_data jsonb) PARTITION BY RANGE(eventdate);
+
+SELECT create_time_partitions('date_partitioned_table', INTERVAL 'infinity', '2022-01-01', '2021-01-01');
+SELECT create_time_partitions('date_partitioned_table', INTERVAL '-infinity', '2022-01-01', '2021-01-01');
+
+-- end of testing interval with infinite values
+
 \set VERBOSITY terse
 SET client_min_messages TO WARNING;
 DROP SCHEMA pg17 CASCADE;