Test for ALTER TABLE SET ACCESS METHOD DEFAULT

update

update

Update src/test/regress/sql/pg17.sql

Co-authored-by: Naisila Puka <37271756+naisila@users.noreply.github.com>

Update src/backend/distributed/commands/table.c

Co-authored-by: Naisila Puka <37271756+naisila@users.noreply.github.com>

update

remove citus tools

update

update

indent

src/backend/distributed/commands/table.c

@@ -3666,6 +3666,24 @@ ErrorIfUnsupportedAlterTableStmt(AlterTableStmt *alterTableStatement)
 
 #if PG_VERSION_NUM >= PG_VERSION_15
 			case AT_SetAccessMethod:
+			{
+				/*
+				 * If command->name == NULL, that means the user is trying to use
+				 * ALTER TABLE ... SET ACCESS METHOD DEFAULT
+				 * which we don't support currently.
+				 */
+				if (command->name == NULL)
+				{
+					ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+									errmsg(
+										"DEFAULT option in ALTER TABLE ... SET ACCESS METHOD "
+										"is currently unsupported."),
+									errhint(
+										"You can rerun the command by explicitly writing the access method name.")));
+				}
+				break;
+			}
+
 #endif
 			case AT_SetNotNull:
 			case AT_ReplicaIdentity:

src/test/regress/expected/pg17.out

@@ -1238,6 +1238,49 @@ ERROR:  Citus does not support COPY FROM with ON_ERROR option.
 COPY check_ign_err FROM STDIN WITH (log_verbosity verbose);
 ERROR:  Citus does not support COPY FROM with LOG_VERBOSITY option.
 -- End of Test for COPY ON_ERROR option
+-- Test for ALTER TABLE SET ACCESS METHOD DEFAULT
+-- Step 1: Local table setup (non-distributed)
+CREATE TABLE test_local_table (id int);
+SELECT citus_add_local_table_to_metadata('test_local_table');
+ citus_add_local_table_to_metadata
+---------------------------------------------------------------------
+
+(1 row)
+
+-- Step 2: Attempt to set access method to DEFAULT on a Citus local table (should fail)
+ALTER TABLE test_local_table SET ACCESS METHOD DEFAULT;
+ERROR:  DEFAULT option in ALTER TABLE ... SET ACCESS METHOD is currently unsupported.
+HINT:  You can rerun the command by explicitly writing the access method name.
+-- Step 3: Setup: create and distribute a table
+CREATE TABLE test_alter_access_method (id int);
+SELECT create_distributed_table('test_alter_access_method', 'id');
+ create_distributed_table
+---------------------------------------------------------------------
+
+(1 row)
+
+-- Step 4: Attempt to set access method to DEFAULT on a distributed table (should fail with your custom error)
+ALTER TABLE test_alter_access_method SET ACCESS METHOD DEFAULT;
+ERROR:  DEFAULT option in ALTER TABLE ... SET ACCESS METHOD is currently unsupported.
+HINT:  You can rerun the command by explicitly writing the access method name.
+-- Step 5: Create and distribute a partitioned table
+CREATE TABLE test_partitioned_alter (id int, val text) PARTITION BY RANGE (id);
+CREATE TABLE test_partitioned_alter_part1 PARTITION OF test_partitioned_alter FOR VALUES FROM (1) TO (100);
+SELECT create_distributed_table('test_partitioned_alter', 'id');
+ create_distributed_table
+---------------------------------------------------------------------
+
+(1 row)
+
+-- Step 6: Attempt to set access method to DEFAULT on a partitioned, distributed table (should fail)
+ALTER TABLE test_partitioned_alter SET ACCESS METHOD DEFAULT;
+ERROR:  DEFAULT option in ALTER TABLE ... SET ACCESS METHOD is currently unsupported.
+HINT:  You can rerun the command by explicitly writing the access method name.
+-- Cleanup
+DROP TABLE test_local_table CASCADE;
+DROP TABLE test_alter_access_method CASCADE;
+DROP TABLE test_partitioned_alter CASCADE;
+-- End of Test for ALTER TABLE SET ACCESS METHOD DEFAULT
 \set VERBOSITY terse
 SET client_min_messages TO WARNING;
 DROP SCHEMA pg17 CASCADE;

src/test/regress/sql/pg17.sql

@@ -621,6 +621,36 @@ COPY check_ign_err FROM STDIN WITH (log_verbosity verbose);
 
 -- End of Test for COPY ON_ERROR option
 
+-- Test for ALTER TABLE SET ACCESS METHOD DEFAULT
+-- Step 1: Local table setup (non-distributed)
+CREATE TABLE test_local_table (id int);
+
+SELECT citus_add_local_table_to_metadata('test_local_table');
+
+-- Step 2: Attempt to set access method to DEFAULT on a Citus local table (should fail)
+ALTER TABLE test_local_table SET ACCESS METHOD DEFAULT;
+
+-- Step 3: Setup: create and distribute a table
+CREATE TABLE test_alter_access_method (id int);
+SELECT create_distributed_table('test_alter_access_method', 'id');
+
+-- Step 4: Attempt to set access method to DEFAULT on a distributed table (should fail with your custom error)
+ALTER TABLE test_alter_access_method SET ACCESS METHOD DEFAULT;
+
+-- Step 5: Create and distribute a partitioned table
+CREATE TABLE test_partitioned_alter (id int, val text) PARTITION BY RANGE (id);
+CREATE TABLE test_partitioned_alter_part1 PARTITION OF test_partitioned_alter FOR VALUES FROM (1) TO (100);
+SELECT create_distributed_table('test_partitioned_alter', 'id');
+
+-- Step 6: Attempt to set access method to DEFAULT on a partitioned, distributed table (should fail)
+ALTER TABLE test_partitioned_alter SET ACCESS METHOD DEFAULT;
+
+-- Cleanup
+DROP TABLE test_local_table CASCADE;
+DROP TABLE test_alter_access_method CASCADE;
+DROP TABLE test_partitioned_alter CASCADE;
+-- End of Test for ALTER TABLE SET ACCESS METHOD DEFAULT
+
 \set VERBOSITY terse
 SET client_min_messages TO WARNING;
 DROP SCHEMA pg17 CASCADE;