[typo] fix wrong comments #7223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HasDistributionKey & HasDistributionKeyCacheEntry returns true when the corresponding table has a distribution key, the comments state the opposite, which should be fixed. Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #7223 +/- ##
==========================================
- Coverage 93.22% 93.21% -0.01%
==========================================
Files 275 275
Lines 59495 59493 -2
==========================================
- Hits 55463 55459 -4
- Misses 4032 4034 +2 |
marcoslot
approved these changes
Oct 18, 2023
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
HasDistributionKey & HasDistributionKeyCacheEntry returns true when the corresponding table has a distribution key, the comments state the opposite, which should be fixed. Signed-off-by: Zhao Junwang <zhjwpku@gmail.com> Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasDistributionKey & HasDistributionKeyCacheEntry returns true when the
corresponding table has a distribution key, the comments state the opposite,
which should be fixed.