Add a test for citus_shards where table names have spaces #7224
Conversation
JelteF
force-pushed
the
citus_shards-test
branch
from
3f13b4f to
b5e240b
Compare
There was a bug reported for previous versions of Citus where shard_size was returning NULL for tables with spaces in them. It works fine on the main branch though, but I'm still adding a test for this to the main branch because it seems a good test to have.
JelteF
force-pushed
the
citus_shards-test
branch
from
b5e240b to
f3819af
Compare
Codecov Report
@@ Coverage Diff @@
## main #7224 +/- ##
=======================================
Coverage 93.22% 93.22%
=======================================
Files 275 275
Lines 59494 59456 -38
=======================================
- Hits 55464 55430 -34
+ Misses 4030 4026 -4 |
| --------------------------------------------------------------------- | ||
| "t with space" | 99456904 | citus_shards."t with space_99456904" | distributed | 456900 | localhost | 57637 | 40960 | ||
| "t with space" | 99456905 | citus_shards."t with space_99456905" | distributed | 456900 | localhost | 57638 | 40960 | ||
| "t with space" | 99456906 | citus_shards."t with space_99456906" | distributed | 456900 | localhost | 57637 | 40960 |
There was a problem hiding this comment.
maybe reduce the columns to avoid flakiness
There was a problem hiding this comment.
The values don't cause flakiness because I reset the relevant sequences at the top of this test to the expected values. I'd rather keep all columns instead so we are actually testing that the the full view works.
There was a problem hiding this comment.
Sizes can also have some variability, but maybe it's fine
There was a problem hiding this comment.
That's fair, we usually start using a range there when they turn out to be variable. I think in this case it's not a problem. But to be clear, the sizes were specifically the issue with the tables with spaces, so I definitely want to include them.
There was a bug reported for previous versions of Citus where shard\_size was returning NULL for tables with spaces in them. It works fine on the main branch though, but I'm still adding a test for this to the main branch because it seems a good test to have.
There was a bug reported for previous versions of Citus where
shard_size was returning NULL for tables with spaces in them. It works
fine on the main branch though, but I'm still adding a test for this to
the main branch because it seems a good test to have.