Adds additional alter database propagation support #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurkanindibay
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7253 +/- ##
==========================================
- Coverage 89.60% 84.26% -5.35%
==========================================
Files 278 350 +72
Lines 60099 62696 +2597
Branches 7487 8126 +639
==========================================
- Hits 53853 52830 -1023
- Misses 4100 7629 +3529
- Partials 2146 2237 +91 |
gurkanindibay
changed the title
halilozanakgul
previously requested changes
Oct 12, 2023
gurkanindibay
changed the title
to fix failing tests
…m/citusdata/citus into alter_database_additional_options
|
I'm checking for Codecov results and see that even the main execution blocks seem uncovered. I think they are false positives |
onurctirtir
reviewed
Dec 25, 2023
4 tasks
onurctirtir
approved these changes
Dec 26, 2023
colm-mchugh
added a commit
that referenced
this pull request
Nov 25, 2024
…lespace seen in database vanilla test (#7764) Disable DDL propagation for the vanilla test suite. This enables the vanilla `database ` test to pass, where previously it was correctly returning `ERROR: unrecognized ALTER DATABASE option: tablespace` because release-13.0 does not propagate this ALTER DATABASE variant. We (Citus team) discussed cherry picking [#7253](#7253) from main to release-13.0 because it does propagate ALTER DATABASE tablespace option (as well as a couple of others) but decided fixing the regress test was not the proper context for that. The fix disables `citus.enable_metadata_sync` when running vanilla, we discussed disabling `citus.enable_create_database_propagation` but this is not in release-13.0.
m3hm3t
pushed a commit
that referenced
this pull request
Nov 28, 2024
…lespace seen in database vanilla test (#7764) Disable DDL propagation for the vanilla test suite. This enables the vanilla `database ` test to pass, where previously it was correctly returning `ERROR: unrecognized ALTER DATABASE option: tablespace` because release-13.0 does not propagate this ALTER DATABASE variant. We (Citus team) discussed cherry picking [#7253](#7253) from main to release-13.0 because it does propagate ALTER DATABASE tablespace option (as well as a couple of others) but decided fixing the regress test was not the proper context for that. The fix disables `citus.enable_metadata_sync` when running vanilla, we discussed disabling `citus.enable_create_database_propagation` but this is not in release-13.0.
m3hm3t
pushed a commit
that referenced
this pull request
Nov 28, 2024
…lespace seen in database vanilla test (#7764) Disable DDL propagation for the vanilla test suite. This enables the vanilla `database ` test to pass, where previously it was correctly returning `ERROR: unrecognized ALTER DATABASE option: tablespace` because release-13.0 does not propagate this ALTER DATABASE variant. We (Citus team) discussed cherry picking [#7253](#7253) from main to release-13.0 because it does propagate ALTER DATABASE tablespace option (as well as a couple of others) but decided fixing the regress test was not the proper context for that. The fix disables `citus.enable_metadata_sync` when running vanilla, we discussed disabling `citus.enable_create_database_propagation` but this is not in release-13.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Adds database connection limit, rename and set tablespace propagation
In this PR, below statement propagations are added
alter database <database_name> with allow_connections = <boolean_value>;
alter database <database_name> rename to <database_name2>;
alter database <database_name> set TABLESPACE <table_space_name>