Remove software-properties-common from dev container after use #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the creation of the devcontainer we need to add a ppa repository, which is easiest done via software-properies-common. As turns out this installes pkexec into the container as a side effect. When vscode tries to attach a debugger it first checks if pkexec is installed as this gives a nicer popup asking for elevation of rights to attach to the process. However, since dev containers don't have a windowing system running pkexec isn't working as expected and thus prevents the debugger from attaching. Without pkexec in the container vscode 'falls back' to plain old sudo which we can run passwordless in the container. For pkexec to be removed we need to first purge software-propertied-common as well as autoremove all packages that were installed due to the installation of said package. By performing this all in one step we minimize the size of the layer we are creating.
thanodnl
commented
Oct 12, 2023
| @@ -109,7 +113,7 @@ WORKDIR /uncrustify/uncrustify-uncrustify-0.68.1/ | |||
| RUN mkdir build | |||
| WORKDIR /uncrustify/uncrustify-uncrustify-0.68.1/build/ | |||
| RUN cmake .. | |||
| RUN make -sj8 | |||
| RUN MAKEFLAGS="-j $(nproc)" make -s | |||
There was a problem hiding this comment.
I know, this could have been a separate PR, but YOLO
I just happened to see this was still hardcoded to the arbitrary 8 parallel jobs. It is only applicable during the building of the devcontainer, but this allows bigger github actions to actually do something significant it ever required.
Codecov Report
@@ Coverage Diff @@
## main #7255 +/- ##
==========================================
- Coverage 93.22% 93.21% -0.02%
==========================================
Files 275 275
Lines 59492 59539 +47
Branches 0 7419 +7419
==========================================
+ Hits 55462 55499 +37
- Misses 4030 4040 +10 |
JelteF
approved these changes
Oct 12, 2023
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
During the creation of the devcontainer we need to add a ppa repository, which is easiest done via software-properies-common. As turns out this installes pkexec into the container as a side effect. When vscode tries to attach a debugger it first checks if pkexec is installed as this gives a nicer popup asking for elevation of rights to attach to the process. However, since dev containers don't have a windowing system running pkexec isn't working as expected and thus prevents the debugger from attaching. Without pkexec in the container vscode 'falls back' to plain old sudo which we can run passwordless in the container. For pkexec to be removed we need to first purge software-propertied-common as well as autoremove all packages that were installed due to the installation of said package. By performing this all in one step we minimize the size of the layer we are creating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the creation of the devcontainer we need to add a ppa repository, which is easiest done via software-properies-common. As turns out this installes pkexec into the container as a side effect.
When vscode tries to attach a debugger it first checks if pkexec is installed as this gives a nicer popup asking for elevation of rights to attach to the process. However, since dev containers don't have a windowing system running pkexec isn't working as expected and thus prevents the debugger from attaching.
Without pkexec in the container vscode 'falls back' to plain old sudo which we can run passwordless in the container.
For pkexec to be removed we need to first purge software-propertied-common as well as autoremove all packages that were installed due to the installation of said package. By performing this all in one step we minimize the size of the layer we are creating.