Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test detection #7291

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix flaky test detection #7291

merged 1 commit into from
Oct 31, 2023

Conversation

JelteF
Copy link
Contributor

@JelteF JelteF commented Oct 31, 2023

PR #7289 broke flaky test detction. This fixes that.

@onurctirtir
Copy link
Member

Tested on #7271.

@onurctirtir onurctirtir self-requested a review October 31, 2023 14:53
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7291 (2644395) into main (83e3fb8) will decrease coverage by 3.65%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7291      +/-   ##
==========================================
- Coverage   93.22%   89.58%   -3.65%     
==========================================
  Files         275      275              
  Lines       59527    59571      +44     
  Branches        0     7423    +7423     
==========================================
- Hits        55495    53365    -2130     
- Misses       4032     4077      +45     
- Partials        0     2129    +2129     

@JelteF JelteF enabled auto-merge (squash) October 31, 2023 14:56
PR #7289 broke flaky test detction. This fixes that.
@JelteF JelteF force-pushed the fix-flaky-test-detection branch from b8904a1 to 2644395 Compare October 31, 2023 15:00
@JelteF JelteF merged commit 81aa660 into main Oct 31, 2023
125 checks passed
@JelteF JelteF deleted the fix-flaky-test-detection branch October 31, 2023 15:59
francisjodi pushed a commit that referenced this pull request Nov 13, 2023
PR #7289 broke flaky test detction. This fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants