Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG17 - ALTER TABLE ... ALTER COLUMN ... SET EXPRESSION command #7814

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

m3hm3t
Copy link
Contributor

@m3hm3t m3hm3t commented Dec 26, 2024

This PR disallows ALTER TABLE ... ALTER COLUMN ... SET EXPRESSION on all Citus table types (local, distributed, and partitioned distributed) by adding an error check in ErrorIfUnsupportedAlterTableStmt. A new regression test verifies that each table type fails with a consistent error message when attempting to set an expression.

@m3hm3t m3hm3t requested a review from Copilot December 26, 2024 15:52
@m3hm3t m3hm3t self-assigned this Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • src/backend/distributed/commands/table.c: Language not supported
  • src/test/regress/expected/pg17.out: Language not supported
  • src/test/regress/sql/pg17.sql: Language not supported
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-13.0@62a00b1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-13.0    #7814   +/-   ##
===============================================
  Coverage                ?   89.62%           
===============================================
  Files                   ?      274           
  Lines                   ?    59728           
  Branches                ?     7452           
===============================================
  Hits                    ?    53531           
  Misses                  ?     4063           
  Partials                ?     2134           

Copy link
Member

@naisila naisila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Remember to rebase to release-13.0 and merge after all tests have passed.

@m3hm3t m3hm3t force-pushed the m3hm3t/set_expr_alter branch from ed62d26 to 9a4bc04 Compare December 27, 2024 10:02
@m3hm3t m3hm3t changed the base branch from m3hm3t/pg17_support to release-13.0 December 27, 2024 10:02
@m3hm3t m3hm3t force-pushed the m3hm3t/set_expr_alter branch from 9a4bc04 to 7222ecc Compare December 27, 2024 10:04
@m3hm3t m3hm3t force-pushed the m3hm3t/set_expr_alter branch from 7222ecc to cc7796a Compare December 27, 2024 12:32
@m3hm3t m3hm3t marked this pull request as ready for review December 27, 2024 12:33
@naisila naisila merged commit 1a33162 into release-13.0 Dec 27, 2024
150 of 159 checks passed
@naisila naisila deleted the m3hm3t/set_expr_alter branch December 27, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants