[WIP] dev/core#5652 - country list is wrong

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/5652

Before

Go to New Individual and open the address section. The country list isn't ordered properly and ignores pinned countries if you have set them.

After

Technical Details

This is obviously not the right fix, but points out where the problem is.

Also a real fix should be against 5.81.

Comments

Billing address fields like on a contribution page are probably still using the pseudoconstant so you won't see the problem there.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[demeritcowboy]

For at least the api_v3_AddressTest::testBuildCountryWithDodgyCountryLimitSetting, 1271236 changed the way getoptions is called, but the way it's called now is problematic because the only thing it does is countrylimit (via the new alterCountry), but since I'm skipping that function in order to return a proper list which also does ordering and pinned countries, the tests are failing since they no longer have either alterCountry or the old getoptions checks.

@colemanw what's the way to do ordering in this new system? Adding an orderBy in alterCountry doesn't work because only where clauses it returns get used.