Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Use shared TabHeader.tpl for contact summary tabs as well #31697

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Jan 2, 2025

Before

  • very slightly different templates for the contact summary tabs inline in Summary.tpl and other tabsets which use TabHeader.tpl
  • hard time keeping track of what keys are expected for tabs (including when using hook_civicrm_tabset ) - different tabsets need different ones
  • contact tabs fallback to a puzzle piece icon, other tabsets do not
  • contact tabs use a url key, other tabs use a link key
  • contact tabs use an id key, other tabs use the array key from the tabs array

After

  • additional parameters in TabHeader.tpl
  • Contact Summary uses the shared template
  • more consistency in the expected values for tabset arrays
  • Manage Event tabs have icons
  • all tabs without an icon will use the default "puzzle piece" fallback
  • all tabs use url key in the template (this is set from the link key if not provided explicitly, for backwards compatibility)
  • all tabs use the array key from the tabs array (this is set from the id key for contact tabs, for backwards compatibility)

Technical Details

Should have very minimal impact on outputted markup for now, but should be a step towards making the markup more consistent.

Copy link

civibot bot commented Jan 2, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 2, 2025
@ufundo ufundo marked this pull request as ready for review January 2, 2025 20:27
@seamuslee001
Copy link
Contributor

@colemanw my guess is no but would there be any implications on the Contact Summary Layout editor with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants