Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gh action + process improvements #2

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

diegomedina248
Copy link
Contributor

@diegomedina248 diegomedina248 commented May 23, 2024

Changes:

  • Add prettier on the frontend (same as backend) and run it (that explains most of the changes on the FE except the App.tsx)
  • Allow to install/run the project from the root
  • GH Action
  • App.tsx change to display the proper gross amount

Each can be run by following the setup on their respective README files, or you can run both at the same time by following these steps:

1. Clone the repository
2. Install dependencies: `npm run install:all`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include which version of Node we're expecting them to use here?

Copy link
Contributor Author

@diegomedina248 diegomedina248 May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, it's in it's respective readmes, but not here, ty!

@diegomedina248 diegomedina248 merged commit bf65399 into main May 28, 2024
1 check passed
@diegomedina248 diegomedina248 deleted the chore/gh-action branch May 28, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants