Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fill-active-human to fill-human-active #650

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Aug 28, 2024

This fits in better with the naming conventions that Etaoin has adopted previously. Compare, for instance, fill-multi and fill-human-multi versus fill-active and fill-human-active.

Amendment to #629

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

This fits in better with the naming conventions that Etaoin has
adopted previously. Compare, for instance, fill-multi and
fill-human-multi versus fill-active and fill-human-active.
@lread lread merged commit 363b425 into clj-commons:master Aug 28, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-629-addendum branch August 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants