Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :fn/enabled #662

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix :fn/enabled #662

merged 2 commits into from
Sep 13, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Sep 12, 2024

Closes #661

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address. Not yet, but I assume a bug fix PR is welcome.

  • This PR contains test(s) to protect against future regressions. This will be forthcoming. I have been adding test cases to the test suit and found this bug during that process.

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

@dgr
Copy link
Contributor Author

dgr commented Sep 12, 2024

I pushed this without running the test suit and it fails a unit test. See updated change set.

@dgr
Copy link
Contributor Author

dgr commented Sep 12, 2024

I pushed the second commit while the test automation was running, so you may see half the various test platforms fail and the other half pass. Re-run the suite for a more accurate look at things.

Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dgr, tx!

@lread lread merged commit 5820ec6 into clj-commons:master Sep 13, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-661-fn-enabled branch September 14, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:fn/enabled doen't work
2 participants