Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception for unknown :fn/* function keywords #670

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Sep 16, 2024

Closes #668

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address. Not yet.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dgr

@lread lread merged commit 5beefe3 into clj-commons:master Sep 16, 2024
48 of 49 checks passed
@dgr dgr deleted the dgr-issue-668-unknown-fn branch October 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling etaoin.impl.xpath/expand with an unknown :fn/* function doesn't throw an exception
2 participants