Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi level #53

Closed
wants to merge 4 commits into from
Closed

Conversation

yaakovLowenstein
Copy link
Contributor

No description provided.

@yaakovLowenstein
Copy link
Contributor Author

This solves the issue where a grandchild template
wants to render a block that does not exist in itself
or the parent template, but exists in the grandparent.

This builds on #45 but is simpler, I am unclear of all that was done in that PR. This PR solves the one issue outlined above.

Should solve #16 and #12

@clokep
Copy link
Owner

clokep commented Jun 28, 2024

@yaakovLowenstein I think that #56 might fix this, but would be curious for more real world testing!

This solves the issue where a grandchild template
wants to render a block that does not exist in itself
or the parent template, but exists in the grandparent.
@yaakovLowenstein
Copy link
Contributor Author

yaakovLowenstein commented Jun 28, 2024

@clokep Just tested #56 and I believe it does solve the issue. Also from what I could tell it didn't look like anything broke

@clokep
Copy link
Owner

clokep commented Jun 28, 2024

@clokep Just tested #56 and I believe it does solve the issue. Also from what I could tell it didn't look like anything broke

Thank you! I think it works and makes the code much simpler, will probably need to do a beta release for it.

@clokep clokep closed this in #56 Jun 28, 2024
@yaakovLowenstein
Copy link
Contributor Author

@clokep Just tested #56 and I believe it does solve the issue. Also from what I could tell it didn't look like anything broke

Thank you! I think it works and makes the code much simpler, will probably need to do a beta release for it.

Ok great! Looking forward. Thanks for updating it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants