Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump golang.org/x/tools from 0.27.0 to 0.28.0 in /tools/goimports #1215

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 5, 2024

Bumps golang.org/x/tools from 0.27.0 to 0.28.0.

Commits
  • 44670c7 go.mod: update golang.org/x dependencies
  • 7eebab3 gopls/internal/golang: support extract variable at top level
  • e334696 gopls/internal/golang: ignore effects for change signature refactoring
  • 3901733 internal/refactor/inline: substitute groups of dependent arguments
  • 61b2408 gopls/internal/golang: add "Extract constant" counterpart
  • c01eead internal/gcimporter: require binary export data header
  • 9a04136 gopls/internal/golang/stubmethods: refine crash into bug report
  • 01e0b05 internal/refactor/inline: fix condition for splice assignment strategy
  • 557f540 gopls/internal/golang: don't offer to move variadic parameters
  • 399ee16 internal/gcimporter: update FindExportData to return a non-negative size
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.27.0 to 0.28.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.27.0...v0.28.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 5, 2024
@dependabot dependabot bot requested a review from prymitive as a code owner December 5, 2024 19:58
@dependabot dependabot bot added the go Pull requests that update Go code label Dec 5, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.68.0-14-g295ecf7
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

Copy link

github-actions bot commented Dec 5, 2024

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.65m ± 1%   39.86m ± 2%       ~ (p=0.105 n=10)
CheckRules-4     8.526 ± 2%    8.524 ± 2%       ~ (p=0.739 n=10)
geomean         581.5m        582.9m       +0.24%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.853 n=10)
CheckRules-4    973.5Mi ± 0%   972.1Mi ± 0%       ~ (p=0.089 n=10)
geomean         163.3Mi        163.2Mi       -0.07%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.638 n=10)
CheckRules-4    14.13M ± 0%   14.12M ± 0%       ~ (p=0.123 n=10)
geomean         1.364M        1.364M       -0.03%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.02%. Comparing base (e6333e3) to head (295ecf7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1215   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         104      104           
  Lines       12556    12556           
=======================================
  Hits        11931    11931           
  Misses        475      475           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prymitive prymitive merged commit 0c925ff into main Dec 5, 2024
19 checks passed
@prymitive prymitive deleted the dependabot/go_modules/tools/goimports/golang.org/x/tools-0.28.0 branch December 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants