Skip to content

Commit

Permalink
Return nothing on no matched email
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshuaTheMiller committed Feb 8, 2023
1 parent c4314d6 commit a14dd4e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion source/GitHubApp/Properties/launchSettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"dotnetRunMessages": true,
"launchBrowser": true,
"launchUrl": "swagger",
"applicationUrl": "https://localhost:7031;http://localhost:5283",
"applicationUrl": "http://localhost:5283",
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Development"
}
Expand Down
3 changes: 2 additions & 1 deletion source/Gttsb.Core/EmailToCloudIdConverter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ public string ToId(string email)
return $"{emailPrepend}{emailWithReplaceableItems}{replaceValue}";
}

return $"{emailPrepend}{emailWithReplaceableItems}{defaultEmailReplace}";
// TODO: this will fail and it should fail. Replace this will actual failure message...
return "";
}
}
}

0 comments on commit a14dd4e

Please sign in to comment.