Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma Correction for Resident Evil 4 #81

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

mqhaji
Copy link
Contributor

@mqhaji mqhaji commented Dec 5, 2024

Summary

  • sRGB -> 2.2 Gamma Correction has been added to Resident Evil 4 Remake
  • The gamma adjustment slider is no longer by luminance, it is now by channel
  • LUT Scaling has been modified to reduce black crush when paired with gamma correction
  • DICE ShoulderStart has been increased as it was too low before and gamma correction also lowers highlights

Justification for Changes

  • Gamma Correction: The display I was originally using at the time of creating these mods was crushing blacks. Blacks are actually not crushed with 2.2 gamma correction. The gamma calibration menus in SDR also seem to imply 2.2 gamma is expected for these games.
  • Gamma Adjustment Slider: The gamma adjustment slider is now an alternative to gamma correction, as emulating 2.2 gamma often looks crushed (though that seems to be the intention of the developers)

- add sRGB -> 2.2 gamma correction
- make bt709Color a float3 as w is unused
- increase DICE ShoulderStart
- compensate for black crush with gamma correction in LUT scaling
- make gamma adjust work by channel instead of by luminance
- add sRGB -> 2.2 gamma correction
- make bt709Color a float3 as w is unused
- increase DICE ShoulderStart
- compensate for black crush with gamma correction in LUT scaling
- make gamma adjust work by channel instead of by luminance
@clshortfuse clshortfuse merged commit 8101663 into clshortfuse:main Dec 5, 2024
3 checks passed
@mqhaji mqhaji deleted the re4gammacorrect branch December 24, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants