-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min_issue
to metadata
#1413
base: dev
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
I know why that test is failing, and its related to a semi-bug that i thought i had documented already (but i apparently didn't). We can work around it with a small change to the test -- i will show you tomorrow or monday. |
The test failure stems from this issue i just created: #1427 You can fix this PR in the meantime by changing the way rows are created and inserted by the failing test... Right now, it creates the rows by a list comprehension and then inserts them all at once. I think that if you move the call to |
Changed that here. Based on the previous failure, I think that's the only spot that needs to change. |
1e29732
to
f994cdf
Compare
Co-authored-by: george <george.haff@gmail.com>
Quality Gate passedIssues Measures |
Closes #232
Summary:
Calculate and include
min_issue
in metadata.Prerequisites:
dev
branchdev