efficiency

codecov · Dec 18, 2024 · 1cdf274 · 1cdf274
1 parent e818ef2
commit 1cdf274
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/graphql_api/types/impacted_file/impacted_file.py b/graphql_api/types/impacted_file/impacted_file.py
@@ -98,10 +98,12 @@ def resolve_segments(
         # segments with no diff changes and at least 1 unintended change
         segments = [segment for segment in segments if segment.has_unintended_changes]
     elif filters.get("has_unintended_changes") is False:
-        # segments with at least 1 diff change
-        segments = [segment for segment in segments if segment.has_diff_changes]
-        for s in segments:
-            s.remove_unintended_changes()
+        new_segments = []
+        for segment in segments:
+            if segment.has_diff_changes:
+                segment.remove_unintended_changes()
+                new_segments.append(segment)
+        segments = new_segments
 
     return SegmentComparisons(results=segments)