2119 fix unknown error (#1061)

codecov · Dec 16, 2024 · e3b3e49 · e3b3e49
1 parent 622b048
commit e3b3e49
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 11 deletions.
diff --git a/upload/tests/views/test_uploads.py b/upload/tests/views/test_uploads.py
@@ -237,7 +237,9 @@ def test_uploads_post(db, mocker, mock_redis):
     )
     response_json = response.json()
     upload = ReportSession.objects.filter(
-        report_id=commit_report.id, upload_extras={"format_version": "v1"}
+        report_id=commit_report.id,
+        upload_extras={"format_version": "v1"},
+        state="started",
     ).first()
     assert response.status_code == 201
     assert all(
@@ -252,7 +254,9 @@ def test_uploads_post(db, mocker, mock_redis):
     )
 
     assert ReportSession.objects.filter(
-        report_id=commit_report.id, upload_extras={"format_version": "v1"}
+        report_id=commit_report.id,
+        upload_extras={"format_version": "v1"},
+        state="started",
     ).exists()
     assert RepositoryFlag.objects.filter(
         repository_id=repository.repoid, flag_name="flag1"
@@ -348,7 +352,9 @@ def test_uploads_post_tokenless(db, mocker, mock_redis, private, branch, branch_
         assert response.status_code == 201
         response_json = response.json()
         upload = ReportSession.objects.filter(
-            report_id=commit_report.id, upload_extras={"format_version": "v1"}
+            report_id=commit_report.id,
+            upload_extras={"format_version": "v1"},
+            state="started",
         ).first()
         assert all(
             map(
@@ -362,7 +368,9 @@ def test_uploads_post_tokenless(db, mocker, mock_redis, private, branch, branch_
         )
 
         assert ReportSession.objects.filter(
-            report_id=commit_report.id, upload_extras={"format_version": "v1"}
+            report_id=commit_report.id,
+            upload_extras={"format_version": "v1"},
+            state="started",
         ).exists()
         assert RepositoryFlag.objects.filter(
             repository_id=repository.repoid, flag_name="flag1"
@@ -496,7 +504,9 @@ def test_uploads_post_token_required_auth_check(
         assert response.status_code == 201
         response_json = response.json()
         upload = ReportSession.objects.filter(
-            report_id=commit_report.id, upload_extras={"format_version": "v1"}
+            report_id=commit_report.id,
+            upload_extras={"format_version": "v1"},
+            state="started",
         ).first()
         assert all(
             map(
@@ -510,7 +520,9 @@ def test_uploads_post_token_required_auth_check(
         )
 
         assert ReportSession.objects.filter(
-            report_id=commit_report.id, upload_extras={"format_version": "v1"}
+            report_id=commit_report.id,
+            upload_extras={"format_version": "v1"},
+            state="started",
         ).exists()
         assert RepositoryFlag.objects.filter(
             repository_id=repository.repoid, flag_name="flag1"
@@ -626,7 +638,9 @@ def test_uploads_post_github_oidc_auth(
     assert response.status_code == 201
     response_json = response.json()
     upload = ReportSession.objects.filter(
-        report_id=commit_report.id, upload_extras={"format_version": "v1"}
+        report_id=commit_report.id,
+        upload_extras={"format_version": "v1"},
+        state="started",
     ).first()
     assert all(
         map(
@@ -640,7 +654,9 @@ def test_uploads_post_github_oidc_auth(
     )
 
     assert ReportSession.objects.filter(
-        report_id=commit_report.id, upload_extras={"format_version": "v1"}
+        report_id=commit_report.id,
+        upload_extras={"format_version": "v1"},
+        state="started",
     ).exists()
     assert RepositoryFlag.objects.filter(
         repository_id=repository.repoid, flag_name="flag1"
@@ -754,7 +770,9 @@ def test_uploads_post_shelter(db, mocker, mock_redis):
     )
 
     upload = ReportSession.objects.filter(
-        report_id=commit_report.id, upload_extras={"format_version": "v1"}
+        report_id=commit_report.id,
+        upload_extras={"format_version": "v1"},
+        state="started",
     ).first()
     assert response.status_code == 201
     ArchiveService(repository)

diff --git a/upload/views/uploads.py b/upload/views/uploads.py
@@ -50,8 +50,7 @@ def create_upload(
     archive_service = ArchiveService(repository)
     # Create upload record
     instance: ReportSession = serializer.save(
-        report_id=report.id,
-        upload_extras={"format_version": "v1"},
+        report_id=report.id, upload_extras={"format_version": "v1"}, state="started"
     )
 
     # Inserts mirror upload record into measurements table. CLI hits this endpoint