-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filter components by id in addition to name #1013
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: graphql_api/types/commit/commit.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 828 828
Lines 19353 19356 +3
=======================================
+ Hits 18579 18582 +3
Misses 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Customer reported a bug in the Components feature here. It appears to happen when component
name
is omitted from thecodecov.yml
.Per our docs, this field is optional:
Adjust in this PR to allow
id
to be used in the match filters alongsidename
. Reviewed our current usage of the existingfilter_by_component_name
helper - they are all used to support various view operations in the internal api and graphql api to be displayed at Codecov UI gazebo. So changing which components are returned by the filter just affects what is displayed on Components related pages on the UI.Also spun off this ticket - as extra cleanup, we can also later update the frontend to pass to the api the ids instead of the names, and then we can pare down this helper to just look at
id
s. We need this api change to go in first in either case to provide the new functionality (filter by id).Closes codecov/engineering-team#2849
If works as expected, it will also close codecov/feedback#557