Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Re-enable failed payment emails #1064

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

This PR re-enables failed payment emails after fixing the template. Also pulls out the logic for fetching admins from owners to a helper function for easier reuse.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review December 17, 2024 16:53
@codecov-notifications
Copy link

codecov-notifications bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (e0a8e09) to head (2f6de24).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   96.01%   96.02%           
=======================================
  Files         828      828           
  Lines       19429    19434    +5     
=======================================
+ Hits        18655    18661    +6     
+ Misses        774      773    -1     
Flag Coverage Δ
unit 92.29% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit dde7496 Dec 17, 2024
18 of 19 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/enable-failed-payment-emails branch December 17, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants