Add 'value' key to the plan representation resolver #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-codecov
changed the title
terry-codecov
approved these changes
Oct 27, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 95.61% 95.62%
=======================================
Files 602 602
Lines 15295 15300 +5
=======================================
+ Hits 14625 14630 +5
Misses 670 670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 95.61% 95.62%
=======================================
Files 602 602
Lines 15295 15300 +5
=======================================
+ Hits 14625 14630 +5
Misses 670 670
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
+ Coverage 95.32 95.52 +0.20
=======================================
Files 714 716 +2
Lines 15584 15706 +122
=======================================
+ Hits 14854 15003 +149
+ Misses 730 703 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
added a commit
that referenced
this pull request
Nov 6, 2023
* main: Test ats run (#229) Release 23.11.2 (#228) feat: Add comparison endpoint for impacted files (#212) Update shared version (#226) feat: add a filter for public/private repo filter for viewableRepositories (#224) fix: speedup flag filtering in GraphQL API (#223) fix: Disable early notify comment (#219) Add 'value' key to the plan representation resolver (#216) 713 adjust available plans in plan service (#214) feat: Allow upload requests originating from Shelter to set storage path (#172)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
Add
valuefield for plan representation to better align on how the frontend's been handling plan data.Historically, our plan object has had it's name under the key
value, which I think is a little generic, so I thought addingplanNameinstead to be more descriptive was the play. Although I still believe this, it's becoming hard to treat some items asplan.valuevsplan.planNamein the client as other endpoints (and the backend) still handles logic internally to use value.What does this PR do?
valueforplan_representationsNotes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.