-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Commit Detail Page File Explorer Tab to Grab Selected Flags #2326
feat: Update Commit Detail Page File Explorer Tab to Grab Selected Flags #2326
Conversation
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #2326 +/- ##
=======================================
Coverage 97.41% 97.42%
=======================================
Files 716 716
Lines 8526 8533 +7
Branches 2094 2090 -4
=======================================
+ Hits 8306 8313 +7
- Misses 217 218 +1
+ Partials 3 2 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2326 +/- ##
=======================================
Coverage 97.41% 97.42%
=======================================
Files 716 716
Lines 8526 8533 +7
Branches 2094 2090 -4
=======================================
+ Hits 8306 8313 +7
Misses 217 217
Partials 3 3
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2326 +/- ##
=====================================
Coverage 97.42 97.42
=====================================
Files 716 716
Lines 8526 8533 +7
Branches 2045 2045
=====================================
+ Hits 8306 8313 +7
Misses 218 218
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2326 +/- ##
=======================================
Coverage 97.41% 97.42%
=======================================
Files 716 716
Lines 8526 8533 +7
Branches 2045 2078 +33
=======================================
+ Hits 8306 8313 +7
+ Misses 218 217 -1
- Partials 2 3 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR focuses on updating the hook that fetches the data for the
CommitDetailPageFileExplorer
and taking those values and passing them along as API args to filter out the response to those that have coverage related to the selected flags.Closes codecov/engineering-team#345
Notable Changes
MissingFileData
componentuseRepoCommitContentsTable
to conditionally pull out flags from the param and pass as a filter argument to the queryCommitDetailFileExplorer
to passhasSelectedFlags
toMissingFileData
component