Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Commit Detail Page File Explorer Tab to Grab Selected Flags #2326

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR focuses on updating the hook that fetches the data for the CommitDetailPageFileExplorer and taking those values and passing them along as API args to filter out the response to those that have coverage related to the selected flags.

Closes codecov/engineering-team#345

Notable Changes

  • Add flags selected case to MissingFileData component
  • Update useRepoCommitContentsTable to conditionally pull out flags from the param and pass as a filter argument to the query
  • Update CommitDetailFileExplorer to pass hasSelectedFlags to MissingFileData component

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit d4bbff4
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/6532a4b2aa34760008e908b6
😎 Deploy Preview https://deploy-preview-2326--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-staging
Copy link

codecov-staging bot commented Oct 19, 2023

Codecov Report

Merging #2326 (d4bbff4) into main (9fcb8c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   97.41%   97.42%           
=======================================
  Files         716      716           
  Lines        8526     8533    +7     
  Branches     2094     2090    -4     
=======================================
+ Hits         8306     8313    +7     
- Misses        217      218    +1     
+ Partials        3        2    -1     
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcb8c1...d4bbff4. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Oct 19, 2023

Codecov Report

Merging #2326 (d4bbff4) into main (9fcb8c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   97.41%   97.42%           
=======================================
  Files         716      716           
  Lines        8526     8533    +7     
  Branches     2094     2090    -4     
=======================================
+ Hits         8306     8313    +7     
  Misses        217      217           
  Partials        3        3           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcb8c1...d4bbff4. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2326 (d4bbff4) into main (9fcb8c1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2326   +/-   ##
=====================================
  Coverage   97.42   97.42           
=====================================
  Files        716     716           
  Lines       8526    8533    +7     
  Branches    2045    2045           
=====================================
+ Hits        8306    8313    +7     
  Misses       218     218           
  Partials       2       2           
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.jsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcb8c1...d4bbff4. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 19, 2023

Codecov Report

Merging #2326 (d4bbff4) into main (9fcb8c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   97.41%   97.42%           
=======================================
  Files         716      716           
  Lines        8526     8533    +7     
  Branches     2045     2078   +33     
=======================================
+ Hits         8306     8313    +7     
+ Misses        218      217    -1     
- Partials        2        3    +1     
Files Coverage Δ
...mitDetailFileExplorer/CommitDetailFileExplorer.jsx 100.00% <100.00%> (ø)
...ilFileExplorer/hooks/useRepoCommitContentsTable.js 100.00% <100.00%> (ø)
.../ContentsTable/MissingFileData/MissingFileData.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcb8c1...d4bbff4. Read the comment docs.

Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicholas-codecov nicholas-codecov merged commit 2901403 into main Oct 20, 2023
29 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-345-update-file-explorer-tab-to-grab-selected-flags branch October 20, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update File Explorer Tab to Grab Selected Flags
2 participants