-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
625 remove flags page for team tier #2330
Conversation
…ove-flags-page-for-team-tier
Codecov Report
@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 33.62% 33.58% -0.05%
==========================================
Files 664 664
Lines 8359 8369 +10
Branches 2071 2093 +22
==========================================
Hits 2811 2811
- Misses 5519 5529 +10
Partials 29 29
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2330 +/- ##
=======================================
- Coverage 33.63 33.59 -0.04
=======================================
Files 664 664
Lines 8359 8369 +10
Branches 2082 2042 -40
=======================================
Hits 2811 2811
- Misses 5526 5536 +10
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 33.62% 33.58% -0.05%
==========================================
Files 664 664
Lines 8359 8369 +10
Branches 2082 2086 +4
==========================================
Hits 2811 2811
- Misses 5526 5536 +10
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
Codecov Report
@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
- Coverage 33.62% 33.58% -0.05%
==========================================
Files 664 664
Lines 8359 8369 +10
Branches 2038 2044 +6
==========================================
Hits 2811 2811
- Misses 5526 5536 +10
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick small thing to fix up some tests descriptions
describe('when user has a team tier', () => { | ||
beforeEach(() => { | ||
setup({ multipleTiers: true }) | ||
}) | ||
|
||
it('renders a blurred image of the table', async () => { | ||
render(<FlagsTab />, { wrapper }) | ||
|
||
await waitFor(() => | ||
expect(testLocation.pathname).toBe('/gh/codecov/gazebo') | ||
) | ||
}) | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure these test descriptions align with whats being tested here 👀
…ove-flags-page-for-team-tier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me thanks for that quick fix 👍
Description
We're hiding the flags over time tab for team tier customers.
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.