Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login link to error message in fileviewer #3377

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Oct 9, 2024

Description

As a temporary fix to https://github.com/codecov/internal-issues/issues/708 and codecov/engineering-team#2580, we will add a redirect to login to remind users to login.

A follow up will include investigating a more reliable way to refresh Github OAuth tokens so this error auto-corrects itself.

BEFORE

Screenshot 2024-10-09 at 2 02 07 PM

AFTER

Screenshot 2024-10-09 at 1 40 19 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Oct 9, 2024

Bundle Report

Changes will increase total bundle size by 707 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.13MB 707 bytes (0.01%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (c80deba) to head (011d7a1).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         802      803    +1     
  Lines       14139    14152   +13     
  Branches     3901     3903    +2     
=======================================
+ Hits        14022    14035   +13     
  Misses        108      108           
  Partials        9        9           
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
src/shared/RawFileViewer/RawFileViewer.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80deba...011d7a1. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (c80deba) to head (011d7a1).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         802      803    +1     
  Lines       14139    14152   +13     
  Branches     3901     3903    +2     
=======================================
+ Hits        14022    14035   +13     
  Misses        108      108           
  Partials        9        9           
Files Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
src/shared/RawFileViewer/RawFileViewer.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80deba...011d7a1. Read the comment docs.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (c80deba) to head (011d7a1).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         802      803    +1     
  Lines       14139    14152   +13     
  Branches     3896     3903    +7     
=======================================
+ Hits        14022    14035   +13     
  Misses        108      108           
  Partials        9        9           
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
src/shared/RawFileViewer/RawFileViewer.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80deba...011d7a1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files         802      803    +1     
  Lines       14139    14152   +13     
  Branches     3901     3903    +2     
=======================================
+ Hits        14022    14035   +13     
  Misses        108      108           
  Partials        9        9           
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
...rectChangesTable/CommitFileDiff/CommitFileDiff.jsx 100.00% <ø> (ø)
src/shared/RawFileViewer/RawFileViewer.tsx 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.96% <ø> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80deba...011d7a1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
011d7a1 Wed, 09 Oct 2024 18:07:06 GMT Cloud Enterprise

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit d88816e Oct 11, 2024
62 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/add-login-link branch October 11, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants