-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login link to error message in fileviewer #3377
Conversation
Bundle ReportChanges will increase total bundle size by 707 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 802 803 +1
Lines 14139 14152 +13
Branches 3901 3903 +2
=======================================
+ Hits 14022 14035 +13
Misses 108 108
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 802 803 +1
Lines 14139 14152 +13
Branches 3901 3903 +2
=======================================
+ Hits 14022 14035 +13
Misses 108 108
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 802 803 +1
Lines 14139 14152 +13
Branches 3896 3903 +7
=======================================
+ Hits 14022 14035 +13
Misses 108 108
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3377 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 802 803 +1
Lines 14139 14152 +13
Branches 3901 3903 +2
=======================================
+ Hits 14022 14035 +13
Misses 108 108
Partials 9 9
... and 2 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
As a temporary fix to https://github.com/codecov/internal-issues/issues/708 and codecov/engineering-team#2580, we will add a redirect to login to remind users to login.
A follow up will include investigating a more reliable way to refresh Github OAuth tokens so this error auto-corrects itself.
BEFORE
AFTER
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.