Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add yarn test all script #3426

Closed
wants to merge 2 commits into from
Closed

chore: Add yarn test all script #3426

wants to merge 2 commits into from

Conversation

calvin-codecov
Copy link
Contributor

Adding an extra script shortcut since our current ones for running vitest use the --changed flag.

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024

Bundle Report

Bundle size has no change ✅

@codecov-qa
Copy link

codecov-qa bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (82661ff) to head (fc90ce1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3426   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14272    14272           
  Branches     3951     3951           
=======================================
  Hits        14151    14151           
  Misses        112      112           
  Partials        9        9
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82661ff...fc90ce1. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (82661ff) to head (fc90ce1).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3426   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14272    14272           
  Branches     3944     3944           
=======================================
  Hits        14151    14151           
  Misses        112      112           
  Partials        9        9
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82661ff...fc90ce1. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (82661ff) to head (fc90ce1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3426   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14272    14272           
  Branches     3944     3951    +7     
=======================================
  Hits        14151    14151           
  Misses        112      112           
  Partials        9        9
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82661ff...fc90ce1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3426   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      808           
  Lines       14272    14272           
  Branches     3944     3951    +7     
=======================================
  Hits        14151    14151           
  Misses        112      112           
  Partials        9        9
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.06% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82661ff...fc90ce1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 22, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7c54992 Tue, 22 Oct 2024 23:40:04 GMT Expired Expired
fc90ce1 Wed, 23 Oct 2024 15:48:44 GMT Cloud Enterprise

suejung-sentry
suejung-sentry reviewed Oct 22, 2024
View reviewed changes
package.json
@@ -12,6 +12,7 @@
"test": "vitest run --changed --config ./vitest.config.mjs",
"test:vite": "yarn test",
"test:watch": "vitest watch --changed --config ./vitest.config.mjs",
"test:all": "vitest run --config ./vitest.config.mjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on swapping test to be all and test:changed for --changed?
My personal flow is yarn test <nameOfFileImWorkingOn> even if I don't make changes across commits

@codecov-staging
Copy link

codecov-staging bot commented Oct 23, 2024 •
edited
Loading

Bundle Report

Bundle size has no change ✅

@calvin-codecov
Copy link
Contributor Author

Closing out in favor of #3428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suejung-sentry suejung-sentry suejung-sentry left review comments

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calvin-codecov @codecov-releaser @ajay-sentry @suejung-sentry