Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ui/BundleTrendChart #3441

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Oct 25, 2024

Description

Pretty simple PR just removing the ui/BundleTrendChart as we no longer use it anywhere.

Closes codecov/engineering-team#2776

Copy link

codecov bot commented Oct 25, 2024

Bundle Report

Changes will decrease total bundle size by 224 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.5MB 169 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.55MB 55 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

Bundle Report

Changes will decrease total bundle size by 117 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm* 5.55MB 52 bytes (0.0%) ⬆️
gazebo-staging-system 5.5MB 169 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (aa1f8f8) to head (f4a41c8).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      806    -2     
  Lines       14269    14254   -15     
  Branches     3949     3939   -10     
=======================================
- Hits        14148    14134   -14     
+ Misses        112      111    -1     
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.12% <ø> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1f8f8...f4a41c8. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (aa1f8f8) to head (f4a41c8).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      806    -2     
  Lines       14269    14254   -15     
  Branches     3942     3939    -3     
=======================================
- Hits        14148    14134   -14     
+ Misses        112      111    -1     
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.12% <ø> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1f8f8...f4a41c8. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      806    -2     
  Lines       14269    14254   -15     
  Branches     3949     3946    -3     
=======================================
- Hits        14148    14134   -14     
+ Misses        112      111    -1     
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.12% <ø> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1f8f8...f4a41c8. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (aa1f8f8) to head (f4a41c8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3441   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         808      806    -2     
  Lines       14269    14254   -15     
  Branches     3949     3939   -10     
=======================================
- Hits        14148    14134   -14     
+ Misses        112      111    -1     
  Partials        9        9           
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.89% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.12% <ø> (+0.06%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1f8f8...f4a41c8. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f4a41c8 Fri, 25 Oct 2024 10:30:25 GMT Cloud Enterprise

@ajay-sentry
Copy link
Contributor

Is there a related ticket we can link?

@nicholas-codecov
Copy link
Contributor Author

Is there a related ticket we can link?

This would be the closest: codecov/engineering-team#2568

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e172fba Oct 28, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-remove-ui-bundle-trend-chart branch October 28, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Cleanup Old Bundle Trend Chart
3 participants