[launch week] Add submission form on the UI #3444
Conversation
|
@codecov-ai-reviewer review |
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
3 similar comments
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
|
❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format. |
|
@codecov-ai-reviewer review |
| const formData: CustomFormData = { | ||
| name: (form.elements.namedItem('name') as HTMLInputElement).value, | ||
| email: (form.elements.namedItem('email') as HTMLInputElement).value, | ||
| phoneNumber: (form.elements.namedItem('phone') as HTMLInputElement).value, |
There was a problem hiding this comment.
The phoneNumber field is being retrieved using the name 'phone'. For consistency and clarity, it should be named 'phoneNumber' in the form as well.
| console.error(message) | ||
| } | ||
|
|
||
| const form = document.querySelector('form') |
There was a problem hiding this comment.
Instead of querying the form element directly in the global scope, consider using a React ref to manage the form element. This will make the code more idiomatic to React and easier to manage.
|
@codecov-ai-reviewer review |
|
I've reviewed this Pull Request and have no helpful feedback. |
Co-authored-by: codecov-ai-reviewer[bot] <156709835+codecov-ai-reviewer[bot]@users.noreply.github.com>
rohitvinnakota-codecov
changed the title
This PR adds a form that validates user input.