Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add back needed z-index style #3447

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: Add back needed z-index style #3447

merged 2 commits into from
Oct 29, 2024

Conversation

calvin-codecov
Copy link
Contributor

Description

Removed z-index rule for CI status tooltip was actually needed

Screenshot 2024-10-29 at 10 05 26 AM

Code Example

Notable Changes

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Oct 29, 2024

Bundle Report

Changes will increase total bundle size by 13 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.55MB 169 bytes (-0.0%) ⬇️
gazebo-staging-system 5.5MB 182 bytes (0.0%) ⬆️

Copy link

codecov bot commented Oct 29, 2024

Bundle Report

Changes will increase total bundle size by 13 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.5MB 182 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.55MB 169 bytes (-0.0%) ⬇️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 29, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f5cfa64 Tue, 29 Oct 2024 17:23:10 GMT Expired Expired
b99aa28 Tue, 29 Oct 2024 17:56:31 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (730e89f) to head (b99aa28).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3447   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         809      809           
  Lines       14297    14297           
  Branches     3949     3949           
=======================================
  Hits        14176    14176           
  Misses        112      112           
  Partials        9        9           
Files with missing lines Coverage Δ
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...b99aa28. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3447   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         809      809           
  Lines       14297    14297           
  Branches     3956     3949    -7     
=======================================
  Hits        14176    14176           
  Misses        112      112           
  Partials        9        9           
Files with missing lines Coverage Δ
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...b99aa28. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (730e89f) to head (b99aa28).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3447   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files         809      809           
  Lines       14297    14297           
  Branches     3949     3956    +7     
=======================================
  Hits        14176    14176           
  Misses        112      112           
  Partials        9        9           
Files Coverage Δ
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.88% <ø> (ø)
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.15% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...b99aa28. Read the comment docs.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (730e89f) to head (b99aa28).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3447       +/-   ##
===========================================
+ Coverage   11.49%   99.15%   +87.65%     
===========================================
  Files         809      809               
  Lines       14297    14297               
  Branches     3956     3949        -7     
===========================================
+ Hits         1644    14176    +12532     
+ Misses      11026      112    -10914     
+ Partials     1627        9     -1618     
Files with missing lines Coverage Δ
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <100.00%> (ø)

... and 725 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (+100.00%) ⬆️
Layouts 100.00% <ø> (+100.00%) ⬆️
Pages 98.88% <ø> (+98.74%) ⬆️
Services 99.45% <ø> (+93.81%) ⬆️
Shared 99.80% <ø> (+89.08%) ⬆️
UI 99.15% <100.00%> (+8.33%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e89f...b99aa28. Read the comment docs.

@calvin-codecov calvin-codecov added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit a8a4b15 Oct 29, 2024
62 checks passed
@calvin-codecov calvin-codecov deleted the cy/add_back_z_index branch October 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants