Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pin default branch to top of branch selector items #3476

Closed
wants to merge 45 commits into from

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR aims to pin the default branch (if it exists) to the top of the list of branches on the Branch Selector for the Failed Tests tab.

This is a quality of life fix to make it easy for folks to go back to the "main" view.

Closes codecov/engineering-team#2855

Screenshots

Screenshot 2024-11-08 at 10 23 10 AM Screenshot 2024-11-08 at 10 23 16 AM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

RulaKhaled and others added 30 commits September 10, 2024 10:44
Co-authored-by: Ajay Singh <ajay.singh@sentry.io>
@ajay-sentry ajay-sentry closed this Nov 8, 2024
@codecov-staging
Copy link

codecov-staging bot commented Nov 8, 2024

Bundle Report

Changes will increase total bundle size by 719 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.83MB 570 bytes (0.01%) ⬆️
gazebo-staging-system 5.77MB 149 bytes (0.0%) ⬆️

Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 4209 tests with 1 failed, 4208 passed and 0 skipped.

View the full list of failed tests

src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx

  • Class name: src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx
    Test name: BillingOptions > when rendered > planString is set to annual plan > renders annual button as "selected"

    Error: expect(element).toHaveClass("bg-ds-primary-base")

    Expected the element to have class:
    bg-ds-primary-base
    Received:
    flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
    ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

@codecov-qa
Copy link

codecov-qa bot commented Nov 8, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4209 1 4208 0
View the top 1 failed tests by shortest run time
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx > BillingOptions &gt; when rendered &gt; planString is set to annual plan &gt; renders annual button as &quot;selected&quot;
Stack Traces | 0.187s run time
Error: expect(element).toHaveClass(&quot;bg-ds-primary-base&quot;)

Expected the element to have class:
  bg-ds-primary-base
Received:
  flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
 ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@codecov-staging
Copy link

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4209 1 4208 0
View the top 1 failed tests by shortest run time
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx > BillingOptions &gt; when rendered &gt; planString is set to annual plan &gt; renders annual button as &quot;selected&quot;
Stack Traces | 0.187s run time
Error: expect(element).toHaveClass(&quot;bg-ds-primary-base&quot;)

Expected the element to have class:
  bg-ds-primary-base
Received:
  flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
 ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

To view more test analytics go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Copy link

codecov bot commented Nov 8, 2024

Bundle Report

Changes will increase total bundle size by 719 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.77MB 149 bytes (0.0%) ⬆️
gazebo-production-system-esm 5.83MB 570 bytes (0.01%) ⬆️

Copy link

codecov bot commented Nov 8, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4209 1 4208 0
View the top 1 failed tests by shortest run time
src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/Controllers/ProPlanController/BillingOptions/BillingOptions.test.tsx > BillingOptions &gt; when rendered &gt; planString is set to annual plan &gt; renders annual button as &quot;selected&quot;
Stack Traces | 0.187s run time
Error: expect(element).toHaveClass(&quot;bg-ds-primary-base&quot;)

Expected the element to have class:
  bg-ds-primary-base
Received:
  flex-1 py-1 px-2 text-sm cursor-pointer whitespace-nowrap disabled:text-ds-gray-quaternary disabled:border-ds-gray-tertiary disabled:bg-ds-gray-primary rounded-l
 ❯ .../ProPlanController/BillingOptions/BillingOptions.test.tsx:144:27

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f5852f8 Fri, 08 Nov 2024 18:29:23 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier way to go to default branch from branch results page
4 participants