-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Flake rate to fixed decimals #3489
Conversation
Bundle ReportChanges will decrease total bundle size by 296 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 296 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3489 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4093 4093
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3489 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4100 4100
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3489 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4093 4093
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3489 +/- ##
=======================================
Coverage 99.09% 99.09%
=======================================
Files 808 808
Lines 14402 14402
Branches 4100 4093 -7
=======================================
Hits 14272 14272
Misses 123 123
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR fixes an issue where flake rate was unbounded coming from API, and bounds it to 2 decimals.
Screenshots
BEFORE
AFTER
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.