Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flake rate to fixed decimals #3489

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix: Flake rate to fixed decimals #3489

merged 1 commit into from
Nov 12, 2024

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR fixes an issue where flake rate was unbounded coming from API, and bounds it to 2 decimals.

Screenshots

BEFORE

Screenshot 2024-11-12 at 1 11 45 PM

AFTER

Screenshot 2024-11-12 at 1 10 58 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Nov 12, 2024

Bundle Report

Changes will decrease total bundle size by 296 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.61MB 168 bytes (-0.0%) ⬇️
gazebo-staging-system 5.56MB 128 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 12, 2024

Bundle Report

Changes will decrease total bundle size by 296 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.56MB 128 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.61MB 168 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (4980a6f) to head (ae49eed).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3489   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4093     4093           
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4980a6f...ae49eed. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3489   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4100     4100           
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4980a6f...ae49eed. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (4980a6f) to head (ae49eed).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3489   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4093     4093           
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4980a6f...ae49eed. Read the comment docs.

Copy link

codecov-public-qa bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (4980a6f) to head (ae49eed).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3489   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files         808      808           
  Lines       14402    14402           
  Branches     4100     4093    -7     
=======================================
  Hits        14272    14272           
  Misses        123      123           
  Partials        7        7           
Files with missing lines Coverage Δ
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 91.86% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.81% <ø> (ø)
Services 99.36% <ø> (ø)
Shared 99.74% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4980a6f...ae49eed. Read the comment docs.

@ajay-sentry ajay-sentry added this pull request to the merge queue Nov 12, 2024
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ae49eed Tue, 12 Nov 2024 21:18:07 GMT Cloud Enterprise

Merged via the queue into main with commit 082770a Nov 12, 2024
62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/flake-rate-fix branch November 12, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants