Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip copy for failed tests #3495

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: Tooltip copy for failed tests #3495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/RepoPage/FailedTestsTab/FailedTestsPage/MetricsSection/MetricsSection.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ describe('MetricsSection', () => {
wrapper: wrapper('/gh/owner/repo/tests/main'),
})

const title = await screen.findByText('Failures')
const title = await screen.findByText('Cumulative Failures')
const context = await screen.findByText(1)
const description = await screen.findByText(
'The number of test failures across all branches.'
Expand Down
6 changes: 3 additions & 3 deletions src/pages/RepoPage/FailedTestsTab/FailedTestsPage/MetricsSection/MetricsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,10 @@ const TotalFailuresCard = ({
<MetricCard>
<MetricCard.Header>
<MetricCard.Title className="flex items-center gap-2">
Failures
Cumulative Failures
<TooltipWithIcon>
The number of failures indicate the number of errors that caused the
tests to fail.
The sum of all test failures, incremented each time any test has
failed.
</TooltipWithIcon>
</MetricCard.Title>
</MetricCard.Header>
Expand Down
Loading