Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update usePullPageData to TSQ V5 #3536

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR updates usePullPageData to PullPageDataQueryOpts as part of our migration over to TS Query V5.

Ticket: codecov/engineering-team#2965

Notable Changes

  • Update usePullPageData to PullPageDataQueryOpts
  • Some tidying up of directories, and getting rid of barrel index files
  • Update tests

@nicholas-codecov nicholas-codecov changed the title chore: update usePullPageData to TSQ V5 chore: Update usePullPageData to TSQ V5 Nov 28, 2024
@codecov-staging
Copy link

codecov-staging bot commented Nov 28, 2024

Bundle Report

Changes will increase total bundle size by 2.1kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 1.11kB (0.02%) ⬆️
gazebo-staging-system 5.67MB 989 bytes (0.02%) ⬆️

Copy link

codecov bot commented Nov 28, 2024

Bundle Report

Changes will increase total bundle size by 2.1kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 989 bytes (0.02%) ⬆️
gazebo-production-system-esm 5.72MB 1.11kB (0.02%) ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 28, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7f58895 Thu, 28 Nov 2024 17:54:06 GMT Expired Expired
659948b Fri, 29 Nov 2024 11:17:08 GMT Cloud Enterprise

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files         806      806           
  Lines       14443    14447    +4     
  Branches     4097     4105    +8     
=======================================
+ Hits        14287    14291    +4     
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ages/PullRequestPage/PullCoverage/PullCoverage.jsx 100.00% <100.00%> (ø)
...PullCoverage/PullCoverageTabs/PullCoverageTabs.jsx 100.00% <ø> (ø)
...age/PullCoverage/PullCoverageTabs/useTabsCounts.ts 100.00% <100.00%> (ø)
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx 100.00% <100.00%> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.56% <100.00%> (+0.26%) ⬆️
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a584b...659948b. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (b2a584b) to head (659948b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files         806      806           
  Lines       14443    14447    +4     
  Branches     4104     4098    -6     
=======================================
+ Hits        14287    14291    +4     
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ages/PullRequestPage/PullCoverage/PullCoverage.jsx 100.00% <100.00%> (ø)
...PullCoverage/PullCoverageTabs/PullCoverageTabs.jsx 100.00% <ø> (ø)
...age/PullCoverage/PullCoverageTabs/useTabsCounts.ts 100.00% <100.00%> (ø)
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx 100.00% <100.00%> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.56% <100.00%> (+0.26%) ⬆️
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a584b...659948b. Read the comment docs.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (b2a584b) to head (659948b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files         806      806           
  Lines       14443    14447    +4     
  Branches     4097     4098    +1     
=======================================
+ Hits        14287    14291    +4     
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ages/PullRequestPage/PullCoverage/PullCoverage.jsx 100.00% <100.00%> (ø)
...PullCoverage/PullCoverageTabs/PullCoverageTabs.jsx 100.00% <ø> (ø)
...age/PullCoverage/PullCoverageTabs/useTabsCounts.ts 100.00% <100.00%> (ø)
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx 100.00% <100.00%> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.56% <100.00%> (+0.26%) ⬆️
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a584b...659948b. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 67b950a Nov 29, 2024
59 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2965-chore-update-usePullPageData-to-tsqv5 branch November 29, 2024 13:11
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (b2a584b) to head (659948b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3536   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files         806      806           
  Lines       14443    14447    +4     
  Branches     4104     4098    -6     
=======================================
+ Hits        14287    14291    +4     
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
...ages/PullRequestPage/PullCoverage/PullCoverage.jsx 100.00% <100.00%> (ø)
...PullCoverage/PullCoverageTabs/PullCoverageTabs.jsx 100.00% <ø> (ø)
...age/PullCoverage/PullCoverageTabs/useTabsCounts.ts 100.00% <100.00%> (ø)
...Page/PullCoverage/routes/FileViewer/FileViewer.jsx 100.00% <100.00%> (ø)
src/pages/PullRequestPage/PullRequestPage.tsx 97.56% <100.00%> (+0.26%) ⬆️
.../PullRequestPage/queries/PullPageDataQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a584b...659948b. Read the comment docs.

Copy link

sentry-io bot commented Dec 5, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch dynamically imported module: https://app.codecov.io/assets/index.CjjySavq0ebtoC9C... /:provider/:owner/:repo/pull/:pullId View Issue
  • ‼️ TypeError: Failed to fetch /:provider/:owner/:repo/pull/:pullId/blob/:path+ View Issue
  • ‼️ SyntaxError: Unexpected token 'u', "upstream c"... is not valid JSON /:provider/:owner/:repo/pull/:pullId View Issue
  • ‼️ TypeError: NetworkError when attempting to fetch resource. /:provider/:owner/:repo/pull/:pullId View Issue
  • ‼️ TypeError: Failed to fetch /:provider/:owner/:repo/pull/:pullId View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants