Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTML Validation issues with GitHub Rate Limit Banner #3538

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR resolves the following issues:

Warning: validateDOMNesting(...): <h2> cannot appear as a child of <h5>.
Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>.

Notable Changes

  • Remove h2 and p elements

Screenshots

Before:
Screenshot 2024-11-28 at 15 21 25

After:

Screenshot 2024-11-28 at 15 17 49

Copy link

codecov bot commented Nov 28, 2024

Bundle Report

Changes will decrease total bundle size by 335 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 78 bytes (-0.0%) ⬇️
gazebo-production-system-esm 5.72MB 257 bytes (-0.0%) ⬇️

@codecov-staging
Copy link

codecov-staging bot commented Nov 28, 2024

Bundle Report

Changes will decrease total bundle size by 335 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 257 bytes (-0.0%) ⬇️
gazebo-staging-system 5.67MB 78 bytes (-0.0%) ⬇️

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (f399f75) to head (772b4c6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3538   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14443    14443           
  Branches     4104     4104           
=======================================
  Hits        14287    14287           
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f399f75...772b4c6. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3538   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14443    14443           
  Branches     4104     4097    -7     
=======================================
  Hits        14287    14287           
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f399f75...772b4c6. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (f399f75) to head (772b4c6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3538   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14443    14443           
  Branches     4097     4104    +7     
=======================================
  Hits        14287    14287           
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f399f75...772b4c6. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
772b4c6 Thu, 28 Nov 2024 19:31:39 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit b2a584b Nov 28, 2024
61 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-issues-with-alert-children-breaking-html-validation-rules branch November 28, 2024 19:40
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (f399f75) to head (772b4c6).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3538   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files         806      806           
  Lines       14443    14443           
  Branches     4104     4104           
=======================================
  Hits        14287    14287           
  Misses        149      149           
  Partials        7        7           
Files with missing lines Coverage Δ
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <ø> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f399f75...772b4c6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants